Re: [2/2 v4 resend] winex11.drv: Implement FlashWindowEx.

[André Hentschel]

Am 03.10.2015 um 05:39 schrieb Jactry Zeng:
> Superseded patch 114739.
>
> ChangeLog:
> v4:
> - Rename driver entry to FlashWindowEx;
> - Put FlashWindowEx/pFlashWindowEx in right place;
> - Add CDECL for X11DRV_FlashWindowEx.
> v3:
> - Use x11drv_atom instead of XInternAtom;
> - Only do XSendEvent() when data->mapped is true.
> v2:
> - Use _NET_WM_STATE_DEMANDS_ATTENTION instead of Urgency.

Hi,
I haven't looked closer, but normally the implementation should be in the Ex-function and the non-Ex-function should call the Ex-function.
In this patch you do Ex->non-Ex->Ex which looks strange.