Re: [PATCH v3 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
> +static DWORD io_tid;
> +
> +struct data_object
> +{
> +    ID3DX10DataLoader ID3DX10DataLoader_iface;
> +    ID3DX10DataProcessor ID3DX10DataProcessor_iface;
> +
> +    HANDLE load_started;
> +    HANDLE load_done;
> +    HANDLE decompress_done;
> +    HRESULT load_ret;
> +
> +    DWORD process_tid;
> +};
> +
> +static struct data_object* data_object_from_ID3DX10DataLoader(ID3DX10DataLoader *iface)
> Nitpick, '*' placement.

Please give a look at the ok() messages introduced in this patch, a number of them can be improved so that they're more consistent with the usual style "Got unexpected %#x.\n" or similar.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/272#note_2444