Re: services: Remove an unused variable.

[Francois Gouget]

On Fri, 26 Aug 2011, Frédéric Delanoy wrote:
[...]
> > -        DWORD err;
> >         const WCHAR *argv[2];
> >         service = services_list[i];
> >         argv[0] = service->name;
> >         argv[1] = NULL;
> > -        err = service_start(service, 1, argv);
> > +        service_start(service, 1, argv);
> >         /* FIXME: do something if the service failed to start */
> >         release_service(service);
> >     }
>
> Wouldn't it be better to do something with err rather than muting (as
> the comment suggests)?

Maybe but what? The FIXME does not even say. In the meantime a FIXME 
comment is not a good enough reason to keep a compilation warning imho. 
And conversely fixing a compilation warning is not 'muting' a FIXME 
comment.


-- 
Francois Gouget <fgouget(a)codeweavers.com>