Re: [PATCH 2/3] gdiplus: Set outer pointer to NULL when image loading functions fail.

[Dmitry Timoshkov]

Qian Hong <qhong(a)codeweavers.com> wrote:
> > Of course it would be more interesting to test gdiplus image loading
> > APIs on a real image file instead of a zero-sized one, probably then
> > you wouldn't get NotImplemented in patch 3/3 either.
>
> Thanks for your thought, but that not the point of my tests:
> +    hfile = CreateFileW(non_shrW, GENERIC_READ, 0, NULL,
> OPEN_EXISTING, FILE_FLAG_DELETE_ON_CLOSE, 0);
> My point is to test a file without share-reading access, so
> GdipCreateStreamOnFile is going to fail no matter if the file is empty
> or not.

But it may not fail or fail some other way in case of a real image.
In any case testing with an empty file is not something that's really
interesting.

-- 
Dmitry.