Re: [PATCH 2/2 resend] devenum: Return S_OK in IMoniker::IsEqual() stub.

[Andrew Eikum]

I'm not sure how application use these monikers, but lying about
moniker equality makes me a little nervous. This doesn't look that
hard to implement correctly.

Andrew

On Fri, Mar 10, 2017 at 06:26:55PM +0800, Jactry Zeng wrote:
> Superseded patch 131295.
>
> Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com>
> ---
>  dlls/devenum/mediacatenum.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

> diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c
> index 66343342c9..3543182cf4 100644
> --- a/dlls/devenum/mediacatenum.c
> +++ b/dlls/devenum/mediacatenum.c
> @@ -530,7 +530,10 @@ static HRESULT WINAPI DEVENUM_IMediaCatMoniker_IsEqual(IMoniker *iface, IMoniker
>  {
>      FIXME("(%p)->(%p): stub\n", iface, pmkOtherMoniker);
>
> -    return E_NOTIMPL;
> +    if (!pmkOtherMoniker)
> +        return E_INVALIDARG;
> +
> +    return S_OK;
>  }
>
> static HRESULT WINAPI DEVENUM_IMediaCatMoniker_Hash(IMoniker *iface, DWORD *pdwHash)

>