Re: [PATCH v3 5/5] comctl32: LVM_INSERTITEM handler should send notifications with uChanged = LVIF_STATE.

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > -    nmlv.uChanged = uChanged ? uChanged : lpLVItem->mask;
> > +    /* According to the tests uChanged in the notification for a new item
> > +     * has only LVIF_STATE flag set.
> > +     */
> > +    if (isNew)
> > +        nmlv.uChanged = LVIF_STATE;
> > +    else
> > +        nmlv.uChanged = uChanged ? uChanged : lpLVItem->mask;
> >       nmlv.lParam = item.lParam;
>
> Shorter way I think is to tweak uChanged like this:
>
> if (isNew) uChanged &= ~LVIF_STATE;

I didn't check if this makes the tests run without todo_wine, but if it
does, then yes, that looks good to me. Are you planning to send your version?

-- 
Dmitry.