Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

[Dmitry Timoshkov]

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote:
> > > + /* Invalid requests - do not need 'fixing'. */
> > > + case FileAllInformation:
> > > + io->u.Status = STATUS_NOT_IMPLEMENTED;
> > > + break;
> > > +
> > > default:
> > > FIXME("Unsupported class (%d)\n", class);
> > > io->u.Status = STATUS_NOT_IMPLEMENTED;
> > > Add a test please, and a comment won't be needed with a test too.
>
> There already is a test in dlls/ntdll/test/file.c. It produces a
> 'fixme:' when it should not. This fixes that.

This is not a fix. A fix is a patch that makes a test pass that previously
did not. You simply silence a harmless fixme.

-- 
Dmitry.