10 Jun
2022
10 Jun
'22
12:03 p.m.
On Fri Jun 10 11:00:08 2022 +0000, **** wrote:
Henri Verbeet replied on the mailing list: ``` On Fri, 10 Jun 2022 at 12:51, Jan Sikorski (@jsikorski) <wine(a)gitlab.winehq.org> wrote:
I'm not sure about the released() procedures - it looks like if we fail to create the dxgi_resource, we decref the texture or buffer and then it gets released with dxgi_resource set to NULL, no? Hmm, right. That's unfortunate though; ideally wined3d_object_released() would only be called on fully initialised objects.
Yes, for QueryInterface() it could be removed, like it's done for buffers. I was thinking removing it later with additional patch to keep the diff size down.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/212#note_1818