Re: [PATCH 5/7] vcomp: Change _vcomp_fork_call_wrapper() args parameter type to void **.

[Paul Gofman]

While looking at this I think I spotted a bug in ARM wrapper
implementation which seems to be copying the first parameter over and
over (doesn't increment the pointers while copying):

                   "3:\tldr x0, [x2], #8\n\t"
                   "str x0, [x10], #8\n\t"
                   "subs w1, w1, #1\n\t"
                   "b.ne 3b\n\t"

But I have no experience with ARM assembly and might be missing
something obvious. I don't have anything set up to build and run Wine
ARM unfortunately to test.


On 2/9/21 02:44, Paul Gofman wrote:
> That is assumed in the asm implementation.
>
> Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com>