Re: [PATCH 2/2] ntdll: Use swapping method to return . and .. as first entries.

[Alexandre Julliard]

Grazvydas Ignotas <notasas(a)gmail.com> writes:
> On Fri, Jul 22, 2011 at 12:30 PM, Alexandre Julliard
> <julliard(a)winehq.org> wrote:
> > Grazvydas Ignotas <notasas(a)gmail.com> writes:
> > >      res = getdents64( fd, data, size );
> >
> > You should find a way to do this only when you do encounter '.' and
> > '..', not on every call.
>
> The main reason I did this on every call is to get d_off of second
> entry (second_entry_pos), i.e. to know when to return ".." in
> ReturnSingleEntry case. The only thing I can think of is caching that
> second entry d_off between calls, dropping it if dev or ino of fd
> changes.

That would be acceptable, as long as it's really only done for the
ReturnSingleEntry case.

-- 
Alexandre Julliard
julliard(a)winehq.org