Re: [PATCH 2/5] ddraw/tests: Don't require a 3D device for test_resource_priority().

[Riccardo Bortolato]

2016-01-04 22:37 GMT+01:00 Stefan Dösinger <stefandoesinger(a)gmail.com>:
> > Am 04.01.2016 um 14:11 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>:
> >
> > This fixes commit b0d4502c29941c31108a53d6c23f9e23196fb7ec.
> > I asked Riccardo about this init change in an earlier version, and afair he said creating cubemaps without a device crashes on some Windows drivers. I can't find the exchange in the archives, it was probably on IRC. Riccardo, do you remember why you made this change?

Hello Stefan,

Unfortunately I don't keep logs and I cannot remember exactly but that
was done to fix a crash in a test bot or a Windows XP VirtualBox VM
(can't remember exactly).

In case of the bot, I guess it has either been fixed or some other
change in the ddraw test code correctly identifies the buggy driver?

Ciao,
Riccardo
> > -        if ((test_data[i].caps2 & DDSCAPS2_CUBEMAP)
> > -                && !(device_desc.dpcTriCaps.dwTextureCaps & D3DPTEXTURECAPS_CUBEMAP))
> > -        {
> > -            skip("Device does not support cubemaps.\n");
> > -            continue;
> > -        }
> > You're creating cubemaps without checking for support now.