On 06/26/15 16:51, Daniel Lehman wrote:
+ days = _Locinfo__Getdays((_Locinfo *)locinfo); Could you please change _Locinfo__Getdays header and make the cast there? Thanks to it we will much _Locinfo__Getdays mangled name. Also _Locinfo__W_Getmonths, _Locinfo__Getmonths and _Locinfo__W_Getdays header needs to be fixed. This will make this cast not needed.
+ len = strlen(days)+1; + this->days = MSVCRT_operator_new(len); + if(this->days) Please handle allocation failures as it's done in other locale classes.
time_get_char* __thiscall time_get_char_ctor_locinfo(time_get_char *this, const _Locinfo *locinfo, unsigned int refs) { - FIXME("(%p %p %d) stub\n", this, locinfo, refs); + TRACE("(%p %p %d)\n", this, locinfo, refs); + locale_facet_ctor_refs(&this->facet, refs); this->facet.vtable = &MSVCP_time_get_char_vtable; + time_get_char__Init(this, locinfo); return NULL; } You forgot to return THIS here.
Thanks, Piotr