Re: [PATCH] libport: Get rid of ffs

[Alexandre Julliard]

Alex Henrie <alexhenrie24(a)gmail.com> writes:
> On Thu, May 28, 2020 at 12:11 PM Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Alex Henrie <alexhenrie24(a)gmail.com> writes:
> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
> > > ---
> > > This function is no longer used in Wine, and __builtin_ffs or
> > > RtlFindLeastSignificantBit can be used instead when writing new code.
> >
> > It's still used in gdi32.
>
> You're right, thanks for catching that. Do you think it would be
> better to use RtlFindLeastSignificantBit in gdi32 or is it better off
> using the system ffs function?

If you want to convert it to RtlFindLeastSignificantBit that's fine.

-- 
Alexandre Julliard
julliard(a)winehq.org