Re: [PATCH v2] vbscript: Support date and time literals.

[Jacek Caban]

Hi Robert,

The patch looks mostly good, but some comments bellow.

On 9/10/21 10:04 PM, Robert Wilhelm wrote:
> +    memcpy( rptr, ptr, len * sizeof(WCHAR));
> +    rptr[len] = 0;
> +    res = VarDateFromStr(rptr, LOCALE_USER_DEFAULT, 0, ret);

This should probably use script->lcid for locale. (Unfortunately, we 
don't have an access to that in parser yet, but we could store 
script_ctx_t or just LCID in parser_ctx_t).


Also, dump_instr_arg should be updated for ARG_DATE.


Thanks,

Jacek