Re: MSI: First go at thread safety for MSI records

23 Dec 2004

Mike McCormack <mike(a)codeweavers.com> writes:
...
Index: dlls/msi/msipriv.h
===================================================================
RCS file: /home/wine/wine/dlls/msi/msipriv.h,v
retrieving revision 1.32
diff -u -r1.32 msipriv.h

--- dlls/msi/msipriv.h	22 Dec 2004 15:05:07 -0000	1.32
+++ dlls/msi/msipriv.h	23 Dec 2004 01:43:40 -0000
@@ -54,6 +54,7 @@
     UINT magic;
     UINT type;
     UINT refcount;
+    CRITICAL_SECTION cs;
     msihandledestructor destructor;
Do you really need a separate critical section for every single MSI
object?  That seems a bit overkill to me.

-- 
Alexandre Julliard
julliard(a)winehq.org

    