Re: [PATCH 1/4] ddraw: SPECULARENABLE defaults to true in IDirect3DDevice2

[Henri Verbeet]

On 20 June 2013 12:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> @@ -4250,7 +4250,12 @@ static HRESULT WINAPI d3d2_CreateDevice(IDirect3D2 *iface, REFCLSID riid,
>      wined3d_mutex_lock();
>      hr = d3d_device_create(ddraw, surface_impl, 2, &device_impl, NULL);
>      if (SUCCEEDED(hr))
> +    {
>          *device = &device_impl->IDirect3DDevice2_iface;
> +        hr = IDirect3DDevice2_SetRenderState(*device, D3DRENDERSTATE_SPECULARENABLE, TRUE);
> +        if (FAILED(hr))
> +            ERR("SetRenderState failed\n");
> +    }
> Why not do this together with the other render state setup in d3d_device_init()?