Re: [PATCH 2/3] server: Fix get_handle for global handles. It doesn't need process for them.

[Vitaliy Margolen]

Alexandre Julliard wrote:
> Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
> > Alexandre Julliard wrote:
> > > Yes, but duplicate_handle has no reason to call get_handle on the dst
> > > Sure there is. How else do I set the requested access mask?
>
> By creating the handle with the correct mask right away, instead of
> setting a wrong mask and patching it up afterwards.

That can only be done if permissions are not checked. I thought it was
clear from the tests that even when expressly prohibited, you can create
a handle with full access rights to the process if you can duplicate handle.
I tried to keep all the changes in the one place (duplicate_handle) and
not spread them around into create_handle.

Vitaliy.