Paul Vriens wrote:
Dmitry Timoshkov wrote:
"Alexander Morozov" <amorozov(a)etersoft.ru> wrote:
Please consistently print GetLastError() values as %u (not %08x or %d), otherwise the test looks good to me. Edit every test in tests/devinst.c or only testRegisterAndGetDetail?
My comment was about newly added code. If there are other places, then they should be fixed as well, but in a separate patch.
Is this just for this file or do you generally want %u instead of %d/%08x ?
I'm just asking as for most of the setupapi errors %08x looks much better than %u (and is easier traceable in the setupapi.h include file). For example: #define ERROR_INVALID_MACHINENAME (APPLICATION_ERROR_MASK|ERROR_SEVERITY_ERROR|0x220) %u : 3758096928 %08x : e0000220 -- Cheers, Paul.