New error: cp: X and X are the same file

[Dan Kegel]

I'm seeing a lot of errors like this lately:
cp: `/home/dank/.local/share/icons/3550_shell32.0.xpm' and
`/home/dank/.local/share/icons/3550_shell32.0.xpm' are the same file

Did the recent rewrite of menu item creation break something?