28 Aug
2008
28 Aug
'08
6:56 p.m.
On Thu, Aug 28, 2008 at 6:52 PM, Sergey Khodych <khodych(a)gmail.com> wrote:
James Hawkins wrote:
There are several things wrong with this patch: * It's way too large. Please split it up. * No tests. You need to write tests to back up these changes.
Are tests necessary for simple stubs? I don't know what kind of tests can be written for stubs, except tests for wrong input parameters.
Your changes move the functions out of the realm of simple stubs. -- James Hawkins