Re: [try 2] [PATCH 03/12] comctl32: Implement Add, ReplaceIcon, GetImageCount, SetImageCount in IImageList

[Henri Verbeet]

2009/11/11 Owen Rudge <orudge(a)codeweavers.com>:
> @@ -2985,15 +2985,37 @@ static ULONG WINAPI ImageListImpl_Release(IImageList *iface)
>  static HRESULT WINAPI ImageListImpl_Add(IImageList *iface, HBITMAP hbmImage,
>      HBITMAP hbmMask, int *pi)
>  {
> -    FIXME("STUB: %p %p %p %p\n", iface, hbmImage, hbmMask, pi);
> -    return E_NOTIMPL;
> +    HIMAGELIST This = (HIMAGELIST) iface;
> +    int ret;
> +
> +    if (!This || !hbmImage || !pi)
> +        return E_FAIL;

I don't know if you have tests for the other parameters, but "iface"
should never be NULL for COM methods.