17 Nov
2018
17 Nov
'18
7:37 a.m.
On 17/11/18 3:40 pm, Dmitry Timoshkov wrote:
Greg Smith <codedonewell(a)gmail.com> wrote:
+ case FileIoPriorityHintInfo: + FIXME( "Ignoring file IO priority hint: %p, %u, %p, %u\n", file, class, info, size ); + return TRUE; It would be helpful to add standard parameter checks.
By standard parameter checks, given that class is effectively checked by the switch, I take that you mean: - Verify the handle is not invalid; - NULL pointer check on info; and - size is consistent with FILE_IO_PRIORITY_HINT_INFO? Thanks for the feedback - this is my first patch, so I appreciate the guidance.