Re: [PATCH v5 1/2] include: Add winusb.h file.

[Zebediah Figura]

On 4/28/22 07:33, Rémi Bernon wrote:
> On 4/14/22 01:36, Mohamad Al-Jaf wrote:
> > +#ifndef _WINUSB_H_
> > +#define _WINUSB_H_
> > +
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> > +typedef PVOID WINUSB_INTERFACE_HANDLE, *PWINUSB_INTERFACE_HANDLE;
> > +
> > +typedef struct _WINUSB_SETUP_PACKET {
> > +    UCHAR   RequestType;
> > +    UCHAR   Request;
> > +    USHORT  Value;
> > +    USHORT  Index;
> > +    USHORT  Length;
> > +} WINUSB_SETUP_PACKET, *PWINUSB_SETUP_PACKET;
> > +
>
> I think the struct packing is wrong, the SDK uses #pragma pack(1) here,
> which probably should use #include "pshpack1.h" / "poppack.h".

It doesn't make a difference in this case, though.