Re: [PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

[James Hawkins]

On Wed, Dec 16, 2009 at 11:09 AM, Juan Lang <juan.lang(a)gmail.com> wrote:
> Hi Amine,
>
> this patch has no functional benefit.  For example,
> -    HRESULT hr;
>
>     TRACE("\n");
>
> -    hr = SMTPTransport_ParseResponse(This, pBuffer, &response);
> -    if (FAILED(hr))
> +    if (FAILED(SMTPTransport_ParseResponse(This, pBuffer, &response)))
>
> This has the dubious benefit of removing a local variable that was
> used before.  I can't fathom why this is a good thing.
> --Juan

Also, you should never pass a function to a macro.  What if FAILED
were defined as:

FAILED(x) (x & MASK1) | (x & MASK2)

?

-- 
James Hawkins