Hi, On 26/11/21 16:40, Francisco Casas wrote:
@@ -1584,7 +1632,10 @@ static void write_sm4_resource_load(struct hlsl_ctx *ctx, break;
case HLSL_RESOURCE_SAMPLE: - hlsl_fixme(ctx, load->node.loc, "Resource sample instruction."); + /* Combined sample expressions were lowered by lower_combined_samples(). */
I don't think this is true in master.
+ assert(load->sampler.var); + write_sm4_sample(ctx, buffer, resource_type, &load->node, &load->resource, &load->sampler, + coords, texcoord_offset); break; Also this patch clashes with Zeb's submitted patch implementing Sample. Again, I would suggest to wait a bit on this one and then rebase on Zeb's once that is accepted, so that we don't have too many conflicts between submissions.
Giovanni.