Francois Gouget wrote:
Merge all the data for a given unit test to a single structure instead of scattering them into multiple hashtables. The new result data structure makes it possible for the same code to work for both group and individual report results. ---
This fixes the many '.' found in the summary table.
winetest/gather | 333 ++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 204 insertions(+), 129 deletions(-)
diff --git a/winetest/gather b/winetest/gather index d032e23..881134a 100755 --- a/winetest/gather +++ b/winetest/gather @@ -37,32 +37,45 @@ $name0 =~ s+^.*/++; my $summary_version=4;
....
+sub min_to_max($) +{ + my ($minmax)=@_; + return $minmax->[0] if ($minmax->[0] == $minmax->[1]); + return "$minmax->[0] to $minmax->[1]"; +} +
Don't we need quotes around "x to y"? Firebug complains about this.
+ my $mm_count=min_to_max($result->{count}); + my $mm_errors=min_to_max($result->{errors}); + my $mm_todos=min_to_max($result->{todos}); + my $mm_skips=min_to_max($result->{skips}); + my $title="$mm_count tests, $mm_errors errors, $mm_todos todos, $mm_skips skips";
Or put the quotes here of course. The results of your latest patches can be seen at: http://test.winehq.org/data/200803191000/ -- Cheers, Paul.