Re: [PATCH v4 06/12] mshtml: Stringify attribute values in IE8+ mode when using setAttribute.

[Jacek Caban]

On 11/18/21 7:43 PM, Gabriel Ivăncescu wrote:
> +        hres = variant_to_nsstr(&AttributeValue, VARIANT_TO_NSSTR_BSTR_DEPEND, &value_str);
>           if(FAILED(hres))
>               return hres;
>
> +        if((V_VT(&AttributeValue) & ~VT_BYREF) != VT_BSTR)
> +            needs_free = TRUE;
> +
> +        V_VT(&AttributeValue) = VT_BSTR;
> +        nsAString_GetData(&value_str, (const WCHAR**)&V_BSTR(&AttributeValue));

This looks ugly to me, the whole VARIANT_TO_NSSTR_BSTR_DEPEND idea does 
not seem right.


Thanks,

Jacek