On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote:
+ todo_wine ok(SUCCEEDED(hres), "get_hash failed: 0x%08x\n", hres); + if(SUCCEEDED(hres)){ + if(str_pass) + ok(strcmp_wa_null(str, exp) == 0, "expected retrieved hash to be L\"%s\", was: %s\n", exp, wine_dbgstr_w(str)); + else + todo_wine ok(strcmp_wa_null(str, exp) == 0, "expected retrieved hash to be L\"%s\", was: %s\n", exp, wine_dbgstr_w(str)); + } +} +
Your Patch is hard to read. Please split the long lines (3 parts are easy) The whole patch can be split in smaller patches.
+static void perform_test(const struct location_test* test)
In the case of a test failure or a crash, there is no chance to know, which test-set failed. A suffix (protocol name or line number) at the start of every ok() can be used to make the normal output as silent as possible. Using a trace before you call perform_tests() works also. That produce a bit noise in the result file, but the test binary is smaller. -- By by ... Detlef