Re: [PATCH] d3dcompiler: Add missing defines, enums and declarations.

[Henri Verbeet]

On Fri, 4 Oct 2019 at 20:12, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
> On Fri, Oct 4, 2019 at 6:07 PM Andrey Gusev <andrey.goosev(a)gmail.com> wrote:
> > typedef enum D3DCOMPILER_STRIP_FLAGS
> >  {
> >      D3DCOMPILER_STRIP_REFLECTION_DATA = 1,
> >      D3DCOMPILER_STRIP_DEBUG_INFO = 2,
> >      D3DCOMPILER_STRIP_TEST_BLOBS = 4,
> > +    D3DCOMPILER_STRIP_PRIVATE_DATA = 8,
> > +    D3DCOMPILER_STRIP_ROOT_SIGNATURE = 10,
> >      D3DCOMPILER_STRIP_FORCE_DWORD = 0x7fffffff
> >  } D3DCOMPILER_STRIP_FLAGS;
>
> You want 0x10 there, or decimal 16. Probably better to use hex
> literals in all these entries for consistency.

And well, sanity.