-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-11-25 12:02, schrieb Henri Verbeet:
On 24 November 2013 23:45, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Am 2013-11-24 11:30, schrieb Henri Verbeet:
Is there a good reason this can't just be fixed first? It's certainly possible, but it comes with a greater risk of regressions and I estimate that it will require a week of duplicated That shouldn't be true, I think. I'll give it another try and see where it leads me.
I've attached the current state of the surface patches for reference. Patches 2 and 26 are simpler without PBOs, and I'll have to duplicate patches 27-29, 33, 41 and 50 in surface.c and then delete or move the code in separate patches. I'd appreciate it if you could take a look at the entire patchset and see if there's anything else you don't like conceptually or if there's another major reordering you want.
I think it's also worth pointing out that the way the volume code uses PBOs isn't a whole lot better than what the surface code does. How would you prefer PBOs to work?
My patchset replaces the xFLAG_PBO flags with a map_binding field and adds resource_get_memory similar to buffer_get_memory. This will also take care of user memory and dib sections. Eventually we want to use PBOs for sysmem surfaces and volumes so the driver doesn't have to create an extra data copy in UpdateTexture / UpdateSurface. This requires ARB_buffer_storage, and I don't think it makes sense to implement this before buffer, surface and volume location and GL BO handling is merged. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSk3RXAAoJEN0/YqbEcdMwbR0P/2627l6lJFpCVzxRaeOl9GkR d9SERwsYHPYjAEkos6YIkiujRmTi7KakIFkUtzP5rZoB9lhguJUDXpFZw2tBhKVY An4LB/cQDRML2i2F0DdCvfdvgC5kH2206KWTst9icOE8ovqNhbUbBYDszsiG0GIA ft/VjfI7R3+0QvbwsPL4PcgKaI/G5GBzrMzUU7MgdMHB9zcVynakPS7AxY+H2XCQ 8lG2f1AmJ50PLF4UUw2xXgUluF9yzTyqijnvwmsrRaDurL6Bly7DG5IZj83A48J7 9qVJq53LUIeATg8ZBJPKqJy0bs8wfyhXpGMRAmgTEgqaxfJc5eZvI8ppSqZUUWHL PriHNmaBm5hEyGbIvOdRjHhzXET9eIGKQBnTm04EEkRSAneLtmTtuSE75tQgEQiN RSPjvIbYmuXBda8SVn4ZyqFyusUvbSo5HZoFlEgDwyl54tKPcF/IICklcOk/YA/+ 7OAYXmgfkkIZLTOo2IobpWKu1PTU2yIb9ivq4RZp8dWhsemje4v+vseZjEBrIZaG zQHyGd3S3ii/fssQRu+vHNrMQKOtbR9Au9rKeBVSPoU9kuHA0uwoJQPFLu4dw51z zvXKRkwMTBXf5OeLRlw4/YHoRsTzIlKsaZ1tElUugx0gfFIC+TrJe17BeLVgFWnt ex/VAj17impWVBtgmQTJ =XN+B -----END PGP SIGNATURE-----