Re: [PATCH 1/3] d3dx9: Rename the ID3DXEffect object and methods

[Matteo Bruni]

On Sun, Feb 24, 2019 at 11:33 PM Michael Stefaniuc <mstefani(a)winehq.org> wrote:
> Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>
> ---
>  dlls/d3dx9_36/effect.c | 536 ++++++++++++++++++++---------------------
>  1 file changed, 264 insertions(+), 272 deletions(-)
>
> diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
> index b0dc366f6b..5bf66011ea 100644
> --- a/dlls/d3dx9_36/effect.c
> +++ b/dlls/d3dx9_36/effect.c
> @@ -148,6 +148,8 @@ struct d3dx_technique
>      struct IDirect3DStateBlock9 *saved_state;
>  };
>
> +#define ID3DXEffectImpl d3dx9_effect

Is it problematic (WRT your following patches, mostly) to just
complete the rename right away and not introduce the define at all?