Re: [PATCH 2/2] ieframe: Return S_OK/VARIANT_FALSE from InternetExplorer::get_Busy.

[Jacek Caban]

On 10/7/19 6:30 AM, Dmitry Timoshkov wrote:
> Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru>
> ---
>   dlls/ieframe/ie.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/ieframe/ie.c b/dlls/ieframe/ie.c
> index 99ec88e7c3..696af66a62 100644
> --- a/dlls/ieframe/ie.c
> +++ b/dlls/ieframe/ie.c
> @@ -349,7 +349,8 @@ static HRESULT WINAPI InternetExplorer_get_Busy(IWebBrowser2 *iface, VARIANT_BOO
>   {
>       InternetExplorer *This = impl_from_IWebBrowser2(iface);
>       FIXME("(%p)->(%p)\n", This, pBool);
> -    return E_NOTIMPL;
> +    *pBool = VARIANT_FALSE;
> +    return S_OK;

Isn't it as easy to implement as returning This->doc_host.busy? Also a 
trivial test would be nice.


Thanks,

Jacek