Re: [PATCH] d3drm/tests: Add tests for IDirect3DRM*::LoadTexture (try 8).

3 Jan 2016

      -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-01-02 um 22:57 schrieb Aaryaman Vasishta:
...
+    for (i = 0, j = 0; i < size;)
+    {
+        if (palettized)
+        {
+            buffer[i++] = j;
+            buffer[i++] = j;
+            buffer[i++] = j++;
+            j %= 256;
+        }
You're still initializing 3 pixels here. This will go wrong if size isn't a multiple of 3.
...
+struct texture_test
+{
+    int version;
+    int w;
+    int h;
+    BOOL palettized;
+    BOOL upside_down;
+};
upside_down is unused.
You can make this an anonymous structure:

static void test_load_texture(void)
{
    static const struct
    {
        int version;
        ...
    }
    tests[] =
    {
        { 1,     100, 100, TRUE  },
        ...
    };
    ...
}

No need to have a global struct declaration.

Re: [PATCH] d3drm/tests: Add tests for IDirect3DRM*::LoadTexture (try 8).

Stefan Dösinger