Re: [PATCH 2/2] winhttp: Support WINHTTP_OPTION_UPGRADE_TO_WEB_SOCKET option

[Hans Leidekker]

On Wed, 2020-06-17 at 15:34 +1000, Alistair Leslie-Hughes wrote:
> diff --git a/dlls/winhttp/winhttp_private.h b/dlls/winhttp/winhttp_private.h
> index 657f82f642..35a1daf063 100644
> --- a/dlls/winhttp/winhttp_private.h
> +++ b/dlls/winhttp/winhttp_private.h
> @@ -154,6 +154,15 @@ struct authinfo
>      BOOL finished; /* finished authenticating */
>  };
>
> +enum websocket_state
> +{
> +    WEBSOCKET_NOT_SUPPORTED,
> +    WEBSOCKET_UPGRADING,
> +    WEBSOCKET_OPEN,
> +    WEBSOCKET_CLOSING,
> +    WEBSOCKET_CLOSED,
> +};

I'm not convinced we need a state tracking variable. I've submitted an
implementation of WinHttpWebSocketCompleteUpgrade that uses a simple flag.