Don't compare file handles to NULL

7 Mar 2007

      Jacek just sent a patch fixing the following bug:

     file = CreateFileW(fileName, GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_READONLY,NULL);
-    if(file) {
+    if(file != INVALID_HANDLE_VALUE) {

This looks like something that could be turned into a nice Smatch test.

Hint, hint...

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
In theory, theory and practice are the same, but in practice they're different.