Re: wininet: Fix a possible NULL pointer deference (Coverity)

[Alexandre Julliard]

Mike McCormack <mike(a)codeweavers.com> writes:
> diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c
> index 24c8506..f24e4ef 100644
> --- a/dlls/wininet/dialogs.c
> +++ b/dlls/wininet/dialogs.c
> @@ -119,10 +119,9 @@ static BOOL WININET_GetAuthRealm( HINTER
>              if( q )
>                  *q = 0;
>          }
> +        strcpyW( szBuf, p );
>      }
>
> -    strcpyW( szBuf, p );
> -
>      return TRUE;
>  }

Do we really want to return the unmodified string in that case?  That
doesn't seem quite right.

-- 
Alexandre Julliard
julliard(a)winehq.org