19 Nov
2007
19 Nov
'07
11:59 a.m.
Gerald Pfeifer <gerald(a)pfeifer.com> writes:
One of the really uncontested ones, I think. ;-)
---------- Forwarded message ---------- From: Gerald Pfeifer <gerald(a)pfeifer.com> To: <wine-patches(a)winehq.org> Date: Thu, 1 Nov 2007 16:10:03 +0100 (CET) Subject: Remove four useless checks in dlls/gdi32/enhmetafile.c
The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so comparing them for >= 0 is a noop which always evaluates to true.
Gerald
ChangeLog: Remove four unnecessary comparisions of DWORD variables for >= 0.
Validating the record is not unnecessary, it just needs to be done correctly by checking for wraparounds etc. -- Alexandre Julliard julliard(a)winehq.org