Re: [PATCH] ole32: LeaveCriticalSection in one exit case (Coverity)

[Dmitry Timoshkov]

Marcus Meissner <marcus(a)jet.franken.de> wrote:
> --- a/dlls/ole32/ifs.c
> +++ b/dlls/ole32/ifs.c
> @@ -217,6 +217,8 @@ static LPVOID WINAPI IMalloc_fnRealloc(LPMALLOC iface,LPVOID pv,DWORD cb) {
>           IMallocSpy_Release(Malloc32.pSpy);
>       Malloc32.SpyReleasePending = FALSE;
>       Malloc32.pSpy = NULL;
> +		/* cb == 0 case will release it some lines below. */
> +		if (cb) LeaveCriticalSection(&IMalloc32_SpyCS);
>       }
>
> if (0==cb) {

Why not unconditionally release the lock before the '0==cb' check?

-- 
Dmitry.