Questions about filename_tests in dlls/shell32/tests/shlexec.c

[Zhenbo Li]

Hello,

I checked wine test errors, and found some errors for
dlls/shell32/tests/shlexec.c[1]. I wanted to fix bugs in
 'static void test_filename(void)'.

However, I can't understand the intention of previous code: All
testcases are put into
'static filename_tests_t filename_tests[]',
then they are tested via a while-loop. I think it is difficult to locate
*which* testcase really fails.

Is re-factoring such code encouraged? If so, I'm glad to do it.

I really appreciate all finds of ideas.

Thank you.

[1]:
http://test.winehq.org/data/aa22a3c4b2e772636163ea50e7245dba01fe7b34/win8_ne...



Zhenbo Li