Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.

[Jacek Caban]

Hi Erich,

On 06/07/12 23:09, Erich E. Hoover wrote:
> +    /* Post the HTML text to the document */
> +    array = SafeArrayCreateVector(VT_VARIANT, 0, 1);
> +    if(!array)
> +        goto cleanup;
> +    hr = SafeArrayAccessData(array, (LPVOID*)&array_param);
> +    if (FAILED(hr))
> +        goto cleanup;
> +    V_VT(array_param) = VT_BSTR;
> +    V_BSTR(array_param) = SysAllocString(html_fragment);
> +    hr = SafeArrayUnaccessData(array);
> +    if (FAILED(hr))
> +        goto cleanup;
> +    hr = IHTMLDocument2_write(html_parsing_doc, array);

Did you test indexes like '<script>alert("really!?")</script>' ? :)
Seriously, HTMLDocument is not the right tool for the job.

Cheers,
Jacek