Those tests could be run here, but any failure of those deleted tests would be an FAudio issue rather than a Wine issue. The way it currently works (Andrew might be able to elaborate if I’ve missed something) is like this: cd FAudio/tests/ make # This will produce a test binary for XAudio2 on Windows, using MinGW and Wine’s XAudio2 headers cd .. mkdir flibitBuild cd flibitBuild cmake .. -DBUILD_TESTS=ON make # This will build FAudio and a test binary for FAudio on your target platform -Ethan
On Feb 19, 2019, at 10:04 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Ethan Lee <elee(a)codeweavers.com> writes:
The tests were moved/ported to FAudio's repository:
https://github.com/FNA-XNA/FAudio/blob/master/tests/xaudio2.c
The only tests that remain are the ones that Wine specifically cares about, mainly the COM and XAPO tests.
Is there a reason not to run the other tests? That looks like an easier way to test, at least for me. I have no idea if the FAudio that I built is working, and building the tests in that tree doesn't seem straightforward.
The XAudio_Allocator is also shared by XAPOFX and XAudio2FX, so it’s already used multiple times excluding XACTEngine. I can still duplicate it however many times, but it introduces a risk of allocators getting mixed, resulting in CustomAllocatorEXT violations.
OK, it seems it's already a bigger mess than I expected, I guess it's not making it much worse ;-)
-- Alexandre Julliard julliard(a)winehq.org