Thank you very much! 2014-03-11 17:35 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>:
I think that MSHTML may make a good GSoC project. The application will probably need some more concrete task. We will also need to see that you're prepared to the task and sending those patches is a good start. If I concentrate on implementing most IHTMLTable* functions, would it be a good idea?
Here are some comments to your patches:
+ + ret = nsAString_Init(&val, v); + if (!ret){ + ERR("nsAString_Init(%s) failed!\n", debugstr_w(v)); + return E_FAIL; + }
In case where you control the value assigned to nsAString, like in this case, use nsAString_InitDepend to avoid unneeded alloc and copy. This is also infailable, so no error checks are needed.
+ nsres = nsIDOMHTMLTableRowElement_SetAlign(This->nsrow, &val); + if (NS_FAILED(nsres)){ + ERR("Set Align(%s) failed!\n", debugstr_w(v)); + nsAString_Finish(&val); + return E_FAIL; + } + + nsAString_Finish(&val);
Release the string just after SetAlign call so that you don't need to do that on each branch.
Same for other patches and they are ready to go to wine-patches.
Thank you for your advice. I'll send my fixed patches soon.
Cheers, Jacek
-- Have a nice day! Zhenbo Li