-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-05-25 um 10:27 schrieb Henri Verbeet:
This is kind of ok because the existing code is like this, but notice the similarity to some of the code in resource_init(). In fact, is there any reason the caller needs to pass "gl_type" to resource_init() instead of letting it figure it out on its own? The idea is to keep the switch between the different 2D types in the 2D texture init parts of the code instead of the generic code.
-static void delete_fbo_attachment(const struct wined3d_gl_info *gl_info) +static void delete_fbo_attachment(const struct wined3d_gl_info *gl_info, Why is "object" a pointer? Symmetry with create_and_bind_fbo_attachment(). But yeah, it's not really necessary, I'll change this.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVYuDJAAoJEN0/YqbEcdMwJO4QAJS9Kb6d/0Wq5ioRpOeK0DI/ pLD7J9/jzRkH1DYNQzdhyH9LtAj4ugIx5XjjzR1tIsVXz8spjSDDMGDVF0QCEa5a wK0fckdV31QdFG81fdLgKsR+U/+ZehFgy4s/lBZugDq+foGpfsbQwLMb/nDzG9AS SEoWVOQYKEfOY3bdpsJxTx/vjK9d6Dt/KVGAlJFEPT5Xm64k74BkBW8MDfmN//Oe +HDdHnaxTi4seDbtcK2NLyHGU+YPaHt1YgK0HtLZW1uJ0IlvrV2O2XrSEmbGQUpu 7EkyNaYvZFJKzB+0EjGZrBIN2M38C0mLn8b9stE/FBAkt42e0YTGbXyo8/DENci6 xkn+ZMH4mtg2IaW9wxO2Xu92YOId3X5tyIYSE2zA+5/hXtCGCxOPdRzjVCO5TvV3 RHUg28pt8RPikHTnglV5NzsL8wuA/yaPgLPj0uGbLCz4t/1OApWnGWX7L5P9v5BT SuW6H9iJHWmXarbobgpHqmmqKA2+sPhmUjHCVJW4OM/WmLUGgRSZ6a0sRrbcXY8P 8bbtWNkhNq2JhaAcVMNJ0PgAvQfEvxSrRQyxAJQgj9Sf87/+KXYy0eV8pwYs8i2A IdBDW0wGW5y+40+08WHAa+k+IC43nMaGT77NhHm+OHLJecEkm671cDi5cQRLX20z RqDmOWRybXghDocnS8WH =70T8 -----END PGP SIGNATURE-----