24 Jul
2008
24 Jul
'08
6:01 p.m.
Hi Detlef, overall your patch looks good to me. One minor suggestion: + /* only newer versions of cryptnet do the cleanup */ + if(!ret && GetLastError() != CRYPT_E_ASN1_BADTAG && + GetLastError() != OSS_DATA_ERROR) { + ok(crl == NULL, "Expected CRL to be NULL\n"); + } Rather than only checking crl when a newer version of cryptnet is available, why not use the broken() macro? We really do expect crl to get cleaned up. --Juan