2014-06-19 8:30 GMT+08:00 Shuai Meng <mengshuaicalendr(a)gmail.com>:
2014-06-17 17:43 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>:
On 06/17/14 07:59, Shuai Meng wrote:
diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index c2b2edd..d21784d 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -1320,8 +1320,24 @@ static HRESULT Global_Int(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIA
static HRESULT Global_Sgn(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) { - FIXME("\n"); - return E_NOTIMPL; + VARIANT v; + HRESULT hres; + + TRACE("(%s)\n", debugstr_variant(arg)); + + assert(args_cnt == 1); + + V_VT(&v) = VT_EMPTY; + hres = VariantChangeType(&v, arg, VARIANT_LOCALBOOL, VT_R8); + if (FAILED(hres)) + return S_OK;
Please use to_double() instead. to_double may need some fixes (it may require similar changes as you did for to_string first).
Yes, to_double is better and simpler.
Jacek
I have tried to_double, but I don't think it is as convenient as
VariantChangeType. I have to add more types such as VT_CY and VT_EMPTY, and they don't work. For example, if 185 switch(V_VT(v)) { 186 case VT_EMPTY: 187 *ret = VT_EMPTY(v); but there is no VT_EMPTY(), how can I give ret whose type is double a "EMPTY" value? Why must we pick up to_double and give up VariantChangeType?