Byeong-Sik Jeon wrote:
ChangeLog: - add more font selecting & linking mechanism support.
Nice work! Some comments: * Please split each fix into a separate patch. This makes patch reviews and isolating regressions easier. A number of small patches will be accepted into the Wine tree faster than one big patch. * There's also alot of unnecessary formatting changes in your patch, which could be avoided. eg.
- LIST_FOR_EACH_ENTRY(family, &font_list, Family, entry) - { + LIST_FOR_EACH_ENTRY(family, &font_list, Family, entry) {
* Please stick to coding style in the file you're change, so that we don't end up with a mix of many different coding styles in the same file. (and you don't add unnecessary changes like the above). thanks, Mike