Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

[Mike Kaplinskiy]

On Tue, Apr 6, 2010 at 1:08 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes:
> > Remove the fd from the poll list so we don't get POLLHUP/POLLERR
> > messages when we ask for no events
>
> This is wrong, even when selecting for no events you want to receive
> POLLHUP/POLLERR. If you really don't want any events you have to use -1
> to remove the fd from the loop. But in general ignoring POLLHUP/POLLERR
> is a bug.
>
> --
> Alexandre Julliard
> julliard(a)winehq.org

Would allowing adding the fd to the poll loop after it has been
removed be more sane? Otherwise we have to resort to ugly things like
sock_try_event (which only half work).

Mike.