Re: shell32/tests: Use GetVersion() to skip a test on Vista

[Nikolay Sivov]

On 12/5/2013 13:48, Zhenbo Li wrote:
> There are few lines in the code:
>
> +    if (ret != ERROR_FILE_NOT_FOUND)
> +    {
> +        /* Vista would throw up a dialog box that we can't suppress */
>
> As this problem only exists in Vista && Windows 2008, so I think use 
> GetVersion() is a better idea.
>
> ---
>  dlls/shell32/tests/shlfileop.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)

It's better as it is, just add a comment about win2008 if you like. The 
rule is to skip basing on functionality instead of simple version check.