Re: [PATCH v3 02/11] ntoskrnl.exe: Implement KeAreApcsDisabled using critical region functions.

[Derek Lesho]

Thank you for all these reviews.  I have submitted v4 to rebase on master
and fix whitespace issues.  I'll address all your issues in v5.

On Thu, Apr 11, 2019 at 3:35 PM Jacek Caban <jacek(a)codeweavers.com> wrote:
> On 4/11/19 8:26 PM, Derek Lesho wrote:
> > @@ -3431,7 +3433,8 @@ void WINAPI ExReleaseResourceForThreadLite(
> > PERESOURCE resource, ERESOURCE_THREA
> >    */
> >   void WINAPI KeEnterCriticalRegion(void)
> >   {
> > -    FIXME(": stub\n");
> > +    TRACE(": semi-stub\n");
> > +    KeGetCurrentThread()->critical_region = TRUE;
> >   }
>
> According to MSDN, those may be called recursively, so you'd need a
> counter here instead.
>
> Thanks,
>
> Jacek