Re: [PATCH v2 3/5] shell32/tests: Add tests for FolderItems.

[Alex Henrie]

2016-07-05 0:26 GMT-06:00 Nikolay Sivov <bunglehead(a)gmail.com>:
> On 05.07.2016 8:47, Alex Henrie wrote:
> > +    if (0) /* crashes on all versions of Windows */
> > +    {
> > +        r = FolderItems_get_Count(items, NULL);
> > +todo_wine
> > +        ok(r == E_INVALIDARG, "expected E_INVALIDARG, got %08x\n", r);
> > +    }
>
> Why do you want to handle this case if it crashes consistently on
> Windows? And todo_wine is not going to do anything in commented block
> obviously.

Good point. Would you like me to remove this code altogether, or just
the todo_wine and ok statement? Also, would you like me to change the
other if (0) blocks to if (GetVersion() > MAKELONG(5,1)) to avoid
having todo_wine's in if (0) blocks?

-Alex